Merged
Conversation
tseaver
suggested changes
May 12, 2021
1 task
f2fcdcf to
4083562
Compare
1 task
tseaver
approved these changes
May 18, 2021
Contributor
Author
|
I'd like to put this one on hold for a day while I investigate why the owl bot migration script didn't copy code from |
30e6b44 to
49cd307
Compare
busunkim96
approved these changes
May 21, 2021
Contributor
Author
|
I couldn't get to the bottom of why the migration script is failing. I'm going to run the commands manually to migrate this repo. |
tseaver
approved these changes
May 25, 2021
Contributor
|
Coverage is failing (under 100%) due to googleapis/gapic-generator-python#632. |
Contributor
|
It looks like the remaining coverage drops were from a combo of (1) lost replacements in noxfile.py (2) missing pytest-asyncio. On the latest commit I was able to get 100% coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates from autosynth to owl bot. owl bot will save time for maintainers as it will automatically open PRs when there are updates in googleapis-gen without requiring maintainers to run
synthtoolto build the client from protos. Additionally, similar to autosynth, PRs will be automatically opened when there are template updates.