feat: use 'update_transforms'#219
Merged
gcf-merge-on-green[bot] merged 7 commits intomasterfrom Oct 10, 2020
Merged
Conversation
Contributor
Author
|
Note to reviewers: commit-by-commit is likely easier than all-at-once: the last commit is just the "copy current JSON files" bit, which doesn't really need review. |
crwilcox
approved these changes
Oct 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
pbs_for_create,pbs_for_set_no_merge,pbs_for_set_with_merge, andpbs_for_updateto match semantics expected by current versions of conformance tests:Write.transformmessages to hold field transforms, inline them asupdate_transformsin the mainWrite.updatemessage (which will always be created now).Copy in the current version of the conftest JSON files and verify.
Closes #217