fix(sample): mitigate flakiness in subscriber_test#304
Merged
anguillanneuf merged 6 commits intogoogleapis:masterfrom Mar 2, 2021
Merged
fix(sample): mitigate flakiness in subscriber_test#304anguillanneuf merged 6 commits intogoogleapis:masterfrom
anguillanneuf merged 6 commits intogoogleapis:masterfrom
Conversation
fixes googleapis#289 fixes googleapis#288 I think there were few problems with the tests. 1. google.api_core.exceptions.Unknown is not retried. 2. number of messages published in test_receive_synchronously_with_lease was 5, but the sample code is fetching 3 messages in bulk. 3. assertion in test_receive_synchronously_with_lease was too strict. 4. failure in subscriber_test was incorrectly considered a failure in teardown of quickstart_test. I hope these changes will mitigate the flakiness.
anguillanneuf
approved these changes
Mar 2, 2021
Contributor
anguillanneuf
left a comment
There was a problem hiding this comment.
Yah, with sync pull, we may not get the specified number of messages, so the test is too strict there.
Using unknown is also better.
LGTM.
Contributor
|
I LGTM'ed too early. Tests are still flaky (might have become flakier) |
Contributor
Author
|
@busunkim96 There is another instnace of |
Contributor
Author
|
@anguillanneuf PTAL |
anguillanneuf
approved these changes
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #289
fixes #288
I think there were few problems with the tests.
was 5, but the sample code is fetching 3 messages in bulk.
teardown of quickstart_test.
I hope these changes will mitigate the flakiness.