samples: publish with error handler and flow control#433
Merged
anguillanneuf merged 1 commit intomasterfrom Jun 23, 2021
Merged
samples: publish with error handler and flow control#433anguillanneuf merged 1 commit intomasterfrom
anguillanneuf merged 1 commit intomasterfrom
Conversation
kamalaboulhosn
approved these changes
Jun 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address @kamalaboulhosn 's comments in #717
The goal of the sample
pubsub_publish_with_error_handleris to show how to handle publish failures. In the current iteration, I want to show how to catch and handleTimeoutError. I know using a generic exception isn't generally recommended by samples rubrics. Let me know if you see a better type of error to catch in this sample.