Conversation
plamut
reviewed
Jun 23, 2021
| def run_sample(): | ||
| _publish_messages(publisher_client, topic, message_num=3) | ||
| _publish_messages(publisher_client, topic, message_num=10) | ||
| time.sleep(10) |
Contributor
There was a problem hiding this comment.
Maybe add a comment why this is needed?
Waiting for a fixed amount of time is of course far from ideal, but if it resolves or at least significantly mitigates the flakiness, it's fine to have it, as flakiness has really been getting into the way recently.
Edit: Whoa, samples tests passed on the first attempt. Could be a coincidence, of course, but it's a good start nevertheless. 🙂
Contributor
Author
There was a problem hiding this comment.
Added a comment. Please take a look now to see if it's sufficient.
plamut
approved these changes
Jun 23, 2021
Contributor
plamut
left a comment
There was a problem hiding this comment.
LGTM and the samples tests seem to be passing without retries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #341 🦕
The stream sometimes gets removed (
UNKNOWNerrors) before the subscriber can successfully pull messages. Pausing to give the subscriber some time to reconnect since this subscription (subscription_sync) is used in two different synchronous pull samples:If this doesn't fix the flaky test, I will consider using two different subscriptions for the two different sync pull samples tests.
The delete schema sample test failure is unrelated. It's known and is flaky due to backend issues.