CI: fix receive_messages_with_exactly_once_delivery_enabled#638
Merged
pradn merged 6 commits intogoogleapis:mainfrom Apr 6, 2022
Merged
CI: fix receive_messages_with_exactly_once_delivery_enabled#638pradn merged 6 commits intogoogleapis:mainfrom
pradn merged 6 commits intogoogleapis:mainfrom
Conversation
pradn
approved these changes
Apr 6, 2022
Contributor
pradn
left a comment
There was a problem hiding this comment.
If we check for exactly-once correctness too, we have to remove the global test as EOS only works for regional publish/subscribe. However, we don't want to be in the business of doing logic tests for a backend in a sample, so it's all good as it stands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate eod tests with regional endpoint and with default publisher client to aid future debugging.
Added "typed_flaky" to regional test.