fix(db_api): update parse_util output for homogeneous statements#233
fix(db_api): update parse_util output for homogeneous statements#233larkee merged 1 commit intogoogleapis:masterfrom
Conversation
| "table": match.group("table_name"), | ||
| "columns": columns, | ||
| "values": rows_list, | ||
| } |
There was a problem hiding this comment.
Nope i think.
There was a problem hiding this comment.
Oh, I see. The docstring correctly documents this behavior. In that case, I don't think this is a breaking change since it is fixing it to match the documented behavior.
|
Please update the title to be more descriptive i.e. The PR title will be used in the release notes. |
larkee
left a comment
There was a problem hiding this comment.
LGTM once the title is updated
| "table": match.group("table_name"), | ||
| "columns": columns, | ||
| "values": rows_list, | ||
| } |
There was a problem hiding this comment.
Oh, I see. The docstring correctly documents this behavior. In that case, I don't think this is a breaking change since it is fixing it to match the documented behavior.
I have changed the title. |
* fix: revert #233 * update docstrings
Fixes #232