fix: fix release tag workflow to fetch all tags first#1700
Merged
Conversation
suztomo
approved these changes
May 23, 2023
Member
suztomo
left a comment
There was a problem hiding this comment.
Alternatively we can make it override old tags. Either handling is fine, because I don't expect this workflow to run against an old release.
Member
|
@mpeddada1 This change doesn't affect the release. This is just an error handling in case there's existing tags. |
|
[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully final follow-up to: #1699
Workflow currently fails if tag is already created. This is because the actions/checkout checks out the code in a fresh workspace that does not contain tags by default. This adds in the step of fetching tags.