fix(Spring CodeGen): Add Spring dependencies to build files and use static types instead of vapor references#1046
Merged
zhumin8 merged 14 commits intoautoconfig-gen-draft2from Nov 21, 2022
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
conflicts and made updates to satisfy tests.
…c-gen-java_gapic_spring.
|
Kudos, SonarCloud Quality Gate passed! |
emmileaf
approved these changes
Nov 18, 2022
zhumin8
added a commit
to GoogleCloudPlatform/spring-cloud-gcp
that referenced
this pull request
Nov 21, 2022
To account for changes in googleapis/sdk-platform-java#1046, Spring related dependencies needs to be added to [WORKSPACE](https://github.com/googleapis/googleapis/blob/38e8b447d173909d3b2fe8fdc3e6cbb3c85442fd/WORKSPACE#L239-L245).
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Adding Spring related dependencies to build files and use static types instead of vapor references.
Benefit of this change:
One caveat is that because
gapic-generator-javais brought intogoogleapisashttp_archivecode addition togoogleapisis also needed to include these libraries. Add below code snippet to WORKSPACE:Updates:
Pending task on
spring-cloud-gcpside:download-repos.shto add Spring dependencies to WORKSPACE as shown above. (fix(codegen): add logic to add spring deps to googleapis/WORKSPACE GoogleCloudPlatform/spring-cloud-gcp#1349)