Skip to content

fix(spring): fix write pom placeholders.#1099

Merged
zhumin8 merged 2 commits intoautoconfig-gen-draft2from
fix-write-pom
Nov 23, 2022
Merged

fix(spring): fix write pom placeholders.#1099
zhumin8 merged 2 commits intoautoconfig-gen-draft2from
fix-write-pom

Conversation

@zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Nov 21, 2022 •
edited
Loading

  • {{starter-version}} are not needed anymore as we inherit version from parent pom.
  • add parent version placeholder. Changes on spring-cloud-gcp side needed.
  • remove redundant groupid.
  • remove versions for spring-cloud-gcp-core and spring-boot-starter, specified in genereated-parent pom

@zhumin8 zhumin8 mentioned this pull request Nov 21, 2022
Merged
1 task
@emmileaf
Copy link
Contributor

emmileaf commented Nov 21, 2022

@zhumin8 Ah, I was also running into the issue that parent version needs to specified in the generated pom. Since we are aligning versions with spring-cloud-gcp, would the ${revision} property in maven be something we could use as an alternative to the {{parent-version}} placeholder?

Together with spring-cloud-gcp side edits, this would look like GoogleCloudPlatform/spring-cloud-gcp@79e0864 as a POC.

@zhumin8 zhumin8 mentioned this pull request Nov 22, 2022
Closed
@zhumin8
Copy link
Contributor Author

zhumin8 commented Nov 22, 2022

@emmileaf Yeah, ${revision} is better here! I'll make the changes.

@zhumin8
Copy link
Contributor Author

zhumin8 commented Nov 23, 2022

reverting the ${revision} for now to un-block generation process setup.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@zhumin8 zhumin8 marked this pull request as ready for review November 23, 2022 16:43
@zhumin8 zhumin8 requested review from a team, blakeli0, diegomarquezp and emmileaf November 23, 2022 16:43
@zhumin8 zhumin8 merged commit 8625e7c into autoconfig-gen-draft2 Nov 23, 2022
@zhumin8 zhumin8 deleted the fix-write-pom branch November 23, 2022 21:45
zhumin8 added a commit to GoogleCloudPlatform/spring-cloud-gcp that referenced this pull request Nov 23, 2022
@zhumin8
fix(codegen): remove version replacement for modules. (#1353)
4898740 
- Remove version replacement for generated modules, these versions should be inferred from parent pom.
- set parent version to project version.
- [x] Also need to adjust relevant placeholder from gapic-generator-java side. googleapis/sdk-platform-java#1099


Using placeholder for parent version for unblocking generation workflow setup. For future improvements:
- Use `revision` to get versions from spring-cloud-gcp parent pom. This will involve changes for all modules with `spring-cloud-gcp` as parent.
@zhumin8 zhumin8 mentioned this pull request Nov 29, 2022
Merged
zhumin8 added a commit that referenced this pull request Dec 1, 2022
@zhumin8
fix(spring): remove dependency versions that should be inherited. (#1102
cc068c9 
)

This is the last item missed in #1099.
@zhumin8 zhumin8 added the spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch. label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegomarquezp diegomarquezp diegomarquezp approved these changes

@blakeli0 blakeli0 Awaiting requested review from blakeli0

+1 more reviewer

@emmileaf emmileaf emmileaf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhumin8 @emmileaf @diegomarquezp