fix(spring): change @Generated description to spring specific.#1103
fix(spring): change @Generated description to spring specific.#1103zhumin8 merged 3 commits intoautoconfig-gen-draft2from
Conversation
|
Couldn't figure out how to add suggestions to unchanged files, but this description is also set in |
| AnnotationNode.builder() | ||
| .setType(FIXED_TYPESTORE.get("Generated")) | ||
| .setDescription("by gapic-generator-java") | ||
| .setDescription("by spring-generator-java") |
There was a problem hiding this comment.
What do we want to call the spring auto config generator once we move the code to spring-cloud-gcp? Maybe we should come up with a long term name and stick to it, spring-generator-java seems a little odd to me. Maybe spring-auto-config-generator or just a generic spring-generator?
There was a problem hiding this comment.
Thanks for the suggestions. spring-generator sounds better to me, to keep it open to expanding beyond auto-config in future.
There was a problem hiding this comment.
Should we add "google" somewhere in there? For instance, google-cloud-spring-generator?
|
Kudos, SonarCloud Quality Gate passed! |
change
@Generateddescription to spring specific and separate from "gapic-generator-java" for client libraries.Also moved relevant annotation from
SpringPackageInfoComposertoSpringComposer.