fix(spring): refactor retry settings to service-level nested property#1140
Closed
emmileaf wants to merge 6 commits intoautoconfig-gen-draft2from
Closed
fix(spring): refactor retry settings to service-level nested property#1140emmileaf wants to merge 6 commits intoautoconfig-gen-draft2from
emmileaf wants to merge 6 commits intoautoconfig-gen-draft2from
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
This was referenced Dec 16, 2022
Contributor
Author
|
Closing in favor of #1143, which extends on top of these commits and adds method-level properties configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR goes together with GoogleCloudPlatform/spring-cloud-gcp#1392 and:
Refactors the current setup with method-level and individual settings to use a nested
Retryobject provided through properties at service-level.Adding method-level property configuration for retry settings will be made incrementally in another PR.