fix(ast): update import generation to cover annotation parameters#1229
Merged
gcf-merge-on-green[bot] merged 2 commits intomainfrom Jan 26, 2023
Merged
fix(ast): update import generation to cover annotation parameters#1229gcf-merge-on-green[bot] merged 2 commits intomainfrom
gcf-merge-on-green[bot] merged 2 commits intomainfrom
Conversation
diegomarquezp
approved these changes
Jan 16, 2023
blakeli0
approved these changes
Jan 26, 2023
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is cherry-picked from an AST fix made in the spring branch (#1208). It fixes
ImportWriterto account for types introduced by annotation parameters, which as enabled in #1012.