fix(spring): switch camelcase conversion logic to use JavaStyle#1245
Merged
emmileaf merged 2 commits intoautoconfig-gen-draft2from Jan 13, 2023
Merged
fix(spring): switch camelcase conversion logic to use JavaStyle#1245emmileaf merged 2 commits intoautoconfig-gen-draft2from
emmileaf merged 2 commits intoautoconfig-gen-draft2from
Conversation
…ocessing e.g. handling abbreviations
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
|
SonarCloud Quality Gate failed. |
zhumin8
approved these changes
Jan 13, 2023
Contributor
zhumin8
left a comment
There was a problem hiding this comment.
Thanks for making these changes. Although no difference in generated code is made, it's good to be in sync with client library for maintenance.
meltsufin
approved these changes
Jan 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches camelcase handling to use align with logic used in generating client libraries, e.g. here. However, it introduces no updates to golden tests for the spring composers, and my local test to regenerate GoogleCloudPlatform/spring-cloud-gcp#1449 using this branch also showed no diff.
I think
spring-cloud-gcpenforces stricter checkstyle rules (fail on warning) than what is used for the client libraries, so a corresponding change has been made on that side to suppress this for a number of files with abbreviation handling edge cases: GoogleCloudPlatform/spring-cloud-gcp#1455