fix: update workflow for refs and multiple artifacts#1695
fix: update workflow for refs and multiple artifacts#1695
Conversation
| git tag ${ARTIFACT_ID}/$VERSION ${{ github.event.inputs.releaseTag }} | ||
| git push origin ${ARTIFACT_ID}/$VERSION | ||
| VERSION=$(grep "^${ARTIFACT_ID}:" versions.txt | cut -d':' -f2 | tr -d '[:space:]') | ||
| TEMP_BRANCH="temp_branch_${ARTIFACT_ID}_$VERSION" |
There was a problem hiding this comment.
I don't think you need a branch to create tags.
There was a problem hiding this comment.
I was running into permissions errors running this on my fork without the new branch creation because my repo settings were not allowing for modification on the workflow files (which since this is a loop, is considered a modification of the workflow file). I added this temp branch step to workaround that issue (not sure it would also be an issue on this repo, but at least it shouldn't hurt).
There was a problem hiding this comment.
Can you show me the permission error that was resolved by creating a branch or deleting the yaml file?
| git checkout -b $TEMP_BRANCH | ||
| git rm .github/workflows/create_additional_release_tag.yaml | ||
| git commit -m "Remove workflow file" | ||
| git tag "${ARTIFACT_ID}/$VERSION" |
There was a problem hiding this comment.
Can you name tag with "v"?
(It follows convention. https://github.com/googleapis/google-cloud-go/tags)
* chore: add 2 minute timeout to GrpcDirectStreamControllerTest * chore: 3 minute timeout to GrpcDirectStreamControllerTest
* deps: update protobuf dependencies to v3.23.1 and update grpc version to 1.55.1
Bumps [requests](https://github.com/psf/requests) from 2.27.1 to 2.31.0. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.27.1...v2.31.0) --- updated-dependencies: - dependency-name: requests dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
I messed up fixing merge conflicts in this PR. Going to open a new one. |
|
[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!
|
|
[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!
|
|
[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!
|
) * chore(java): update gcp-releasetool and cryptography in java requirements file Source-Link: https://togithub.com/googleapis/synthtool/commit/74d0956884c1bb9dc901b52de35ca2bca025a74e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:142286d973c7b6d58186070f203b50058a20a7d7b42147996db24921a18da1b0
…1017) * chore(java): update gcp-releasetool and cryptography in java requirements file Source-Link: https://togithub.com/googleapis/synthtool/commit/74d0956884c1bb9dc901b52de35ca2bca025a74e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:142286d973c7b6d58186070f203b50058a20a7d7b42147996db24921a18da1b0
Follow up to #1692
This fixes an error in the workflow if it is triggered via release, and also corrects for multiple artifacts that begin with
gax.