test: Update the gapic-generator and hermetic-build golden files' copyright to 2025#3550
Merged
test: Update the gapic-generator and hermetic-build golden files' copyright to 2025#3550
Conversation
lqiu96
approved these changes
Jan 7, 2025
blakeli0
approved these changes
Jan 7, 2025
Contributor
blakeli0
left a comment
There was a problem hiding this comment.
Thanks Min! Can you please make it clear that these golden files do not fail the unit tests? And they might get cleaned up in the future.
Contributor
Author
|
Updated description to provide more info. |
Contributor
Author
|
Hermetic library generation upon generation config change through pull requests / library_generation (pull_request) Failing after 31m Based on description in script here: I am not sure if this test should run on this pr? UPDATE: hint from above error, merge main into this resolved it. |
|
|
lqiu96
pushed a commit
that referenced
this pull request
Feb 20, 2025
…yright to 2025 (#3550) follow-up to #3513, Changes in this PR: - generated by ` mvn test -DupdateUnitGoldens ` from gapic-generator-java/. Note that unit tests without this change did not fail. Filed #3556 to investigate and maybe remove these in the future. - library-generation unit test golden files. They are causing test failures in https://github.com/googleapis/sdk-platform-java/actions/runs/12659566586/job/35278951040?pr=3462 These 2 files are used in unit tests to test logic in owlbot to insert header when they are missing. e.g. https://github.com/googleapis/sdk-platform-java/blob/67f5ea23f50eaf57925cdf34d51c7b0bfcc67cf3/hermetic_build/library_generation/owlbot/synthtool/languages/java.py#L113-L116
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up to #3513,
Changes in this PR:
mvn test -DupdateUnitGoldensfrom gapic-generator-java/. Note that unit tests without this change did not fail. Filed investigate if test golden files are orphaned #3556 to investigate and maybe remove these in the future.sdk-platform-java/hermetic_build/library_generation/owlbot/synthtool/languages/java.py
Lines 113 to 116 in 67f5ea2