Skip to content

chore: add configuration for protobuf-4.x-rc branch#3997

Merged
diegomarquezp merged 1 commit intomainfrom
diegomarquezp-patch-3
Dec 2, 2025
Merged

chore: add configuration for protobuf-4.x-rc branch#3997
diegomarquezp merged 1 commit intomainfrom
diegomarquezp-patch-3

Conversation

@diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Dec 2, 2025

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Dec 2, 2025
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Dec 2, 2025

Summary of Changes

Hello @diegomarquezp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the protobuf-4.x-rc branch into the automated release management system. By adding specific release-please configurations, it ensures that releases originating from this branch are handled correctly, facilitating a streamlined and consistent release process for pre-major versions.

Highlights

  • Release Please Configuration: Added a new branch configuration for protobuf-4.x-rc to the .github/release-please.yml file.
  • Branch Release Parameters: Configured specific release parameters for the protobuf-4.x-rc branch, including bumpMinorPreMajor: true, handleGHRelease: true, manifest: true, and releaseType: java-yoshi.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@diegomarquezp
Copy link
Contributor Author

diegomarquezp commented Dec 2, 2025

The validation error is not about this branch entry:

[
{
"instancePath": "/branches/4",
"schemaPath": "#/allOf/1/properties/branches/items/additionalProperties",
"keyword": "additionalProperties",
"params": {
"additionalProperty": "primaryBranch"
},
"message": "must NOT have additional properties"
}
]

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 2, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds configuration for the protobuf-4.x-rc branch to the .github/release-please.yml file. The configuration seems mostly correct, but I've identified a potential inconsistency in the releaseType that could impact how release pull requests are generated for this branch. My feedback includes a suggestion to align the configuration with the mono-repo setup indicated in release-please-config.json.

.github/release-please.yml
bumpMinorPreMajor: true
handleGHRelease: true
manifest: true
releaseType: java-yoshi
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There appears to be an inconsistency between the releaseType specified here (java-yoshi) and the release-type in release-please-config.json (java-yoshi-mono-repo). Using the java-yoshi type might cause release-please to overlook mono-repo-specific settings defined in release-please-config.json, such as group-pull-request-title-pattern. This could lead to incorrectly formatted release pull requests. To ensure the mono-repo configuration is fully respected, consider aligning the release type.

    releaseType: java-yoshi-mono-repo

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2025

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2025

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@diegomarquezp diegomarquezp merged commit 46b2cee into main Dec 2, 2025
59 of 61 checks passed
@diegomarquezp diegomarquezp deleted the diegomarquezp-patch-3 branch December 2, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@diegomarquezp @blakeli0