chore: Add comment context on null protobuf check [ggj]#754
Merged
chore: Add comment context on null protobuf check [ggj]#754
Conversation
Codecov Report
@@ Coverage Diff @@
## master #754 +/- ##
==========================================
+ Coverage 91.66% 91.68% +0.01%
==========================================
Files 140 140
Lines 14697 14727 +30
Branches 1051 1051
==========================================
+ Hits 13472 13502 +30
Misses 941 941
Partials 284 284
Continue to review full report at Codecov.
|
...com/google/api/generator/gapic/composer/common/AbstractServiceStubSettingsClassComposer.java
Outdated
Show resolved
Hide resolved
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release *beep* *boop* --- ### [2.5.8](googleapis/java-core@v2.5.7...v2.5.8) (2022-03-08) ### Dependencies * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.2.8 ([#753](googleapis/java-core#753)) ([06a4fa6](googleapis/java-core@06a4fa6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #752.