Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## main #882 +/- ##
==========================================
+ Coverage 87.84% 87.89% +0.05%
==========================================
Files 153 155 +2
Lines 15966 16044 +78
Branches 1155 1155
==========================================
+ Hits 14025 14102 +77
- Misses 1601 1602 +1
Partials 340 340
Continue to review full report at Codecov.
|
vam-google
reviewed
Jan 22, 2022
Contributor
vam-google
left a comment
There was a problem hiding this comment.
Thanks for doing it! Looks like a big milestone in gapic-generator's life.
Looking at the code it seems like in this specific PR the ExecutableSampleComposer is capable of generating a basic class skeleton (with main() method and stuff), but is not doing real client runnable examples, calling client library yet. Is it correct? If yes, can you please clarify in PR descritpion:
- what kind of functionality this specific PR (in its current state) ads to gapic generator.
- how is it triggered (now) during generation of gapic clients
- what would be the next step/PR?
- do you anticipate samples differ depending on the transport used (grpc or REST)? note, client instantiation differs depending on if it is grpc or rest client.
Thanks
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release *beep* *boop* --- ## [2.8.4](googleapis/java-core@v2.8.3...v2.8.4) (2022-07-27) ### Documentation * update javadocs for ReadChannel#limit to be more clear ([#880](googleapis/java-core#880)) ([942e8cc](googleapis/java-core@942e8cc)) ### Dependencies * Update google-cloud-shared-config to v1.5.3 ([#882](googleapis/java-core#882)) ([5997769](googleapis/java-core@5997769)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/207550139, b/207550144
go/java-sample-gen
go/java-sample-gen-bugs