chore: Use typing.TYPE_CHECKING instead of MYPY#1503
Merged
erikwrede merged 2 commits intographql-python:masterfrom Jun 4, 2023
Merged
chore: Use typing.TYPE_CHECKING instead of MYPY#1503erikwrede merged 2 commits intographql-python:masterfrom
typing.TYPE_CHECKING instead of MYPY#1503erikwrede merged 2 commits intographql-python:masterfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1503 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 51 51
Lines 1755 1755
=======================================
Hits 1685 1685
Misses 70 70
☔ View full report in Codecov by Sentry. |
Member
|
Thanks! 😊 |
erikwrede
approved these changes
Jun 4, 2023
typing.TYPE_CHECKING to provide generalized waytyping.TYPE_CHECKING instead of MYPY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello graphene!
I found that the code base is using
MYPYas a constant to tell whether a type checker is running.According to the mypy docs, however,
mypyintroduces a more commonly used constant:typing.TYPE_CHECKING. So I'd like to suggest using this rather thanMYPY.As
typing.TYPE_CHECKINGhas been added since Python 3.5.2 andgraphenesupports from Python 3.6, there would be no problem with backporting.Reference: