Revert "Netty upgrade to 4.1.110 in grpc-java (#11273)"#11440
Merged
ejona86 merged 1 commit intogrpc:masterfrom Aug 2, 2024
Merged
Revert "Netty upgrade to 4.1.110 in grpc-java (#11273)"#11440ejona86 merged 1 commit intogrpc:masterfrom
ejona86 merged 1 commit intogrpc:masterfrom
Conversation
This reverts commit f9b072c. Changes from the release process got mixed in with the commit.
Member
Author
|
Hmm... staring at this a little closer, I see multiple of the commits got reverted. Seems maybe only the README was changed. Although that still makes the original commit hard to backport. |
Member
Author
|
No, MODULE.bazel, build.gradle are also messed up. Maybe because of a merge. |
larry-safran
approved these changes
Aug 2, 2024
Contributor
larry-safran
left a comment
There was a problem hiding this comment.
It looks like this was combined with upgrade steps, so Keenan will need to do those upgrade steps separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit f9b072c.
Changes from the release process got mixed in with the commit.
CC @kannanjgithub