Skip to content

Comments

support altsCallCredentials in GoogleDefaultChannelCredentials#11634

Merged
ejona86 merged 4 commits intogrpc:masterfrom
rockspore:gdcc
Oct 24, 2024
Merged

support altsCallCredentials in GoogleDefaultChannelCredentials#11634
ejona86 merged 4 commits intogrpc:masterfrom
rockspore:gdcc

Conversation

@rockspore
Copy link
Collaborator

@rockspore rockspore commented Oct 24, 2024

No description provided.

@rockspore rockspore marked this pull request as ready for review October 24, 2024 17:36
@matthewstevenson88 matthewstevenson88 self-requested a review October 24, 2024 17:43
@rockspore
Copy link
Collaborator Author

rockspore commented Oct 24, 2024

No test exists for GoogleDefaultChannelCredentials so I didn't add any but mainly tested the inner logic, which is also very simple.

@rockspore
Copy link
Collaborator Author

rockspore commented Oct 24, 2024

@ejona86 Aside from this PR, do you mind adding me to grpc-java GitHub team so that I can assign reviewers myself? Thanks.

@ejona86
Copy link
Member

ejona86 commented Oct 24, 2024

All you need to do is @ the people you want to take a look. The more valuable piece is generally to have the CI auto-run, but it did that already. Probably because you have write access to C.

I've given you triage permission, so now you should be able to assign people with issues and PRs and mess with labels.

matthewstevenson88
matthewstevenson88 reviewed Oct 24, 2024
View reviewed changes
Copy link
Contributor

@matthewstevenson88 matthewstevenson88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the ALTS direction. Deferring to @ejona86 for gRPC review.

@matthewstevenson88 matthewstevenson88 requested review from ejona86 and matthewstevenson88 and removed request for matthewstevenson88 October 24, 2024 18:23
ejona86
ejona86 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tell me when you're ready and I'll merge it.

@rockspore rockspore requested a review from ejona86 October 24, 2024 22:01
@rockspore
Copy link
Collaborator Author

rockspore commented Oct 24, 2024

@ejona86 It should be ready. Thanks a lot for quickly reviewing the PR!

@rockspore rockspore mentioned this pull request Oct 24, 2024
Merged
@ejona86 ejona86 merged commit ba8ab79 into grpc:master Oct 24, 2024
ejona86
ejona86 reviewed Oct 24, 2024
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (approval had been reset)

(And now it is there again? Dunno. Whatever. LOOKS GOOD)

@rockspore rockspore deleted the gdcc branch October 24, 2024 22:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ejona86 ejona86 ejona86 approved these changes

@matthewstevenson88 matthewstevenson88 matthewstevenson88 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rockspore @ejona86 @matthewstevenson88