Let AndroidComponentAddress specify a target UserHandle#11670
Merged
jdcormie merged 9 commits intogrpc:masterfrom Nov 19, 2024
Merged
Let AndroidComponentAddress specify a target UserHandle#11670jdcormie merged 9 commits intogrpc:masterfrom
jdcormie merged 9 commits intogrpc:masterfrom
Conversation
ejona86
reviewed
Nov 8, 2024
Member
ejona86
left a comment
There was a problem hiding this comment.
I know this is draft, but a few drive-by comments. Looks fair.
binder/src/main/java/io/grpc/binder/AndroidComponentAddress.java
Outdated
Show resolved
Hide resolved
ejona86
reviewed
Nov 14, 2024
binder/src/main/java/io/grpc/binder/AndroidComponentAddress.java
Outdated
Show resolved
Hide resolved
ejona86
approved these changes
Nov 18, 2024
binder/src/main/java/io/grpc/binder/AndroidComponentAddress.java
Outdated
Show resolved
Hide resolved
Contributor
|
@ejona86 This change LGTM. Discussed with John offline for this change. Making the target UserHandle as part of the AndroidComponentAddress makes sense for two reasons:
|
Member
Author
|
Thanks Wentao! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The target UserHandle is best modeled as part of the SocketAddress since it's part of the server's location.
This change allows a NameResolver to select different target users over time within a single Channel.