[CSM] Use xds-enabled server and xds credentials in examples#11706
Merged
yashykt merged 1 commit intogrpc:masterfrom Nov 26, 2024
Merged
[CSM] Use xds-enabled server and xds credentials in examples#11706yashykt merged 1 commit intogrpc:masterfrom
yashykt merged 1 commit intogrpc:masterfrom
Conversation
DNVindhya
approved these changes
Nov 26, 2024
Contributor
DNVindhya
left a comment
There was a problem hiding this comment.
Changes LGTM.
Can you fill in the PR description as well?
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change -
The CSM Observability examples will now use an xDS enabled server and xds credentials with a fallback on insecure credentials. This allows users to try configuring authn/mtls and authz/rbac using the same example images.
(Existing example uses a non-xds enabled server and insecure credentials.)