xds: Add grpc.target value for xDS enabled server metrics#11715
Merged
DNVindhya merged 1 commit intogrpc:masterfrom Nov 27, 2024
Merged
xds: Add grpc.target value for xDS enabled server metrics#11715DNVindhya merged 1 commit intogrpc:masterfrom
grpc.target value for xDS enabled server metrics#11715DNVindhya merged 1 commit intogrpc:masterfrom
Conversation
grpc.target value for xDS enabled serversgrpc.target value for xDS enabled server metrics
ejona86
approved these changes
Nov 27, 2024
Member
ejona86
left a comment
There was a problem hiding this comment.
The better reference here is probably fallback. https://github.com/grpc/proposal/blob/master/A71-xds-fallback.md#update-csds-to-aggregate-configs-from-multiple-xdsclient-instances says servers use #server. The metrics gRFC is just saying "the same thing applies here"
Contributor
Author
Thanks for the background, updated PR description to refer to A71 instead. |
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Dec 6, 2024
…grpc#11715) As mentioned in [A71 xDS Fallback]( https://github.com/grpc/proposal/blob/master/A71-xds-fallback.md#update-csds-to-aggregate-configs-from-multiple-xdsclient-instances): updated dataplane target to "#server" for xDS-enabled gRPC servers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to gRFC A71 xDS Fallback:
Updated dataplane target value to "#server" for xDS enabled servers.
The dataplane target value of "#server" will also be used as
grpc.targetattribute value for xDS client metrics implemented in #11661.