optimize number of buffer allocations#11879
Merged
ejona86 merged 16 commits intogrpc:masterfrom Feb 14, 2025
Merged
Conversation
ejona86
reviewed
Feb 4, 2025
Member
|
I think I see what you're trying to do, but I'm not sure this is how we want to do it. You've basically realized that we needed the minimum allocation size for unknown message sizes/compression. It seems we should quickly revert the Netty/Servlet changes, since those are known to cause regressions. And I need to stare at this more. CC @shivaspeaks |
Member
|
CC @AgraVator |
ejona86
reviewed
Feb 11, 2025
core/src/main/java/io/grpc/internal/WritableBufferAllocator.java
Outdated
Show resolved
Hide resolved
ejona86
approved these changes
Feb 13, 2025
Member
|
Checkstyle is annoying being upset with FIRST_BUFFER_SIZE. But, yeah, you'll need to move it a bit. Thank you for noticing the issues and adjusting the code! I'm really glad you noticed before we did the release. |
larry-safran
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently this improves 2 flows
Known length message which length is greater than 1Mb
previously the first buffer was 1Mb, and then many buffers of 4096 bytes (from CodedOutputStream), now subsequent buffers are also up to 1Mb
in case of compression, the first write is always 10 bytes buffer (gzip header), but worth allocating more space