Update to latest OkHttp master.#2
Closed
JakeWharton wants to merge 1 commit intogrpc:masterfrom
JakeWharton:jw/okhttp-latest
Closed
Update to latest OkHttp master.#2JakeWharton wants to merge 1 commit intogrpc:masterfrom JakeWharton:jw/okhttp-latest
JakeWharton wants to merge 1 commit intogrpc:masterfrom
JakeWharton:jw/okhttp-latest
Conversation
Member
|
We'll probably wait on it a bit, unless I'm missing something. Since there weren't any functional changes, we can still advertise h2-16 with the existing code. There is a non-zero cost to upgrading our okhttp version internally so I figure just wait until we get something for it. (Especially since okhttp doesn't provide SNAPSHOT binaries to Maven Central) Do note that the change would also need to update the git submodule that we now have in lib/. |
Contributor
Author
|
Sounds good.
I'm actively working on this :)
Ah, I didn't see these happen. Will keep in mind for the future. |
Closed
Contributor
|
Now that OkHttp 2.2.0 is final and in mvn central |
zpencer
added a commit
to zpencer/grpc-java
that referenced
this pull request
Jun 1, 2017
songy23
pushed a commit
to songy23/grpc-java
that referenced
this pull request
Oct 30, 2017
Add dependency for opencensus_contrib_grpc_metrics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if you need to track this internally first. h2-16 was just merged into OkHttp though.