Fix typo in license name#247
Merged
sf105 merged 1 commit intohamcrest:masterfrom Jan 22, 2019
akowal:master
Merged
Conversation
Change license name from "BSD Licence 3" to "BSD License 3". This typo fails automated license checks in a project that has hamcrest dependency.
Member
|
This isn't to say that the change should be rejected. I do want to point out that "licence" with a "c" is not a typo. It is an alternative spelling for the word. "License" with and "s" is the American spelling. As this is a project primarly by people in the UK it is understandable the the non-American spelling is used in the project. |
Contributor
Author
|
@zaphod42 In this case it's not about spelling difference. It is a typo since correct name of the license is |
Member
|
Accepted. For curiosity, what is the check that’s running? |
Contributor
Author
This was referenced Apr 29, 2021
This was referenced May 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change license name from "BSD Licence 3" to "BSD License 3". This typo
fails automated license checks in a project that has
hamcrest dependency.