Upgrade nesbot/carbon ^3.0#7230
Closed
kingIZZZY wants to merge 3 commits intohyperf:masterfrom
kingIZZZY:upgrade-carbon-3.0
Closed
Upgrade nesbot/carbon ^3.0#7230kingIZZZY wants to merge 3 commits intohyperf:masterfrom kingIZZZY:upgrade-carbon-3.0
kingIZZZY wants to merge 3 commits intohyperf:masterfrom
kingIZZZY:upgrade-carbon-3.0
Conversation
Contributor
|
There is already a PR similar to this update #6591 |
Contributor
Author
|
Great - will try continuing efforts on that one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nesbot/carbon version 2 under PHP 8.4 throws:
Fatal error: During class fetch: Uncaught ErrorException: Carbon\Traits\Date::getDaysFromStartOfWeek(): Implicitly marking parameter $weekStartsAt as nullable is deprecated, the explicit nullable type must be used instead in vendor/nesbot/carbon/src/Carbon/Traits/Date.php:1394Would be solved by upgrading to at least ^3.0
Maybe could even upgrade all the way to latest ^3.8 ?...
This is also needed to support similar Carbon upgrade for swooletw/laravel-hyperf dependent on: