Fixed bug that Hyperf\Database\Migrations\Migrator::reset() cannot support string paths.#7449
Merged
limingxinleo merged 3 commits intohyperf:masterfrom Jul 15, 2025
Merged
Fixed bug that Hyperf\Database\Migrations\Migrator::reset() cannot support string paths.#7449limingxinleo merged 3 commits intohyperf:masterfrom
Hyperf\Database\Migrations\Migrator::reset() cannot support string paths.#7449limingxinleo merged 3 commits intohyperf:masterfrom
Conversation
Member
代码审查评论概述此PR修复了 分析结果✅ 问题识别正确
✅ 解决方案质量良好
✅ 代码风格良好
建议
安全与性能
最终评估✅ 推荐通过 - 这是一个清晰、专注的错误修复，解决了合理的类型不匹配问题，遵循框架约定并保持向后兼容性。 |
Hyperf\Database\Migrations\Migrator::reset() cannot support string paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reset方法接收paths参数允许array和string类型，在reset方法中调用的resetMigrations方法的接收参数paths只允许array类型，在reset方法中未对paths的数据类型进行处理。
调用reset方法时，若paths参数为string类型，会报错“Hyperf\Database\Migrations\Migrator::resetMigrations(): Argument #2 ($paths) must be of type array, string given”，因此使用Arr::wrap()方法对paths参数进行处理，确保传递的参数为array类型。