Fix macro validation for reference parameters#7501
Merged
limingxinleo merged 2 commits intohyperf:masterfrom Aug 18, 2025
Merged
Fix macro validation for reference parameters#7501limingxinleo merged 2 commits intohyperf:masterfrom
limingxinleo merged 2 commits intohyperf:masterfrom
Conversation
…pter formatting - Added validation in Macroable trait to prevent macros with reference parameters - Added InvalidArgumentException with descriptive message for reference parameter detection - Added comprehensive test case for reference parameter validation - Fixed formatting issues in Redis adapter LUA scripts (removed extra newlines) - Improved code consistency in Prometheus Redis adapter
limingxinleo
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two issues:
Changes
Macroable::macro()method to detect and reject closures with reference parametersInvalidArgumentExceptionwith descriptive error message when reference parameters are detectedTesting
testParametersPassedByReference()inMacroableTest.phpImpact
InvalidArgumentExceptionType of Change