feat(component): add meilisearch for hyperf scout#7504
Merged
limingxinleo merged 4 commits intohyperf:masterfrom Sep 3, 2025
liangguifeng:master
Merged
feat(component): add meilisearch for hyperf scout#7504limingxinleo merged 4 commits intohyperf:masterfrom liangguifeng:master
limingxinleo merged 4 commits intohyperf:masterfrom
liangguifeng:master
Conversation
Member
|
代码评审(#7504) 总体结论
改进建议
推荐表述
位置建议(可选)
|
huangdijia
reviewed
Aug 19, 2025
Member
huangdijia
left a comment
There was a problem hiding this comment.
正式 Review(评论)
结论
- 该 PR 仅修改文档,风险低;以下为建议性(非阻塞)修改。
建议
- 文案一致性:包名统一使用反引号
laravel/scout、hyperf/scout。 - 专有名词大小写:使用 “Meilisearch” 正确大小写。
- 格式细节:去掉 “Hyperf
scout” 中多余空格。
推荐表述
- liangguifeng/hyperf-scout-meilisearch 适配
hyperf/scout的 Meilisearch 驱动(参考laravel/scout)。
Contributor
Author
|
@huangdijia 您好,已按照 Review 意见进行修改,同时,我个人认为既然适配了 |
huangdijia
previously approved these changes
Aug 29, 2025
limingxinleo
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
参考Laravel
scout适配 Hyperfscout的meilisearch组件