Fixed bug that the parameter context on redis cluster cannot work when auth config isn't set or set with null value.#7554
Merged
limingxinleo merged 4 commits intohyperf:masterfrom Oct 28, 2025
Conversation
leocavalcante
previously approved these changes
Oct 7, 2025
leocavalcante
previously approved these changes
Oct 7, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where Redis cluster connections with TLS context configuration would fail when authentication is not configured or set to null. The issue prevented proper TLS setup as documented in the phpredis extension.
- Replaced conditional auth parameter addition with null coalescing operator
- Ensures consistent parameter ordering for RedisCluster constructor calls
- Enables proper TLS context configuration without requiring auth credentials
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
huangdijia
previously approved these changes
Oct 8, 2025
srgoogle23
approved these changes
Oct 8, 2025
gustamms
approved these changes
Oct 9, 2025
d1fab97
limingxinleo
approved these changes
Oct 28, 2025
huangdijia
approved these changes
Oct 28, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix a issue that you cannot use context config without set auth config.
The isset ignore null config causing the creation of RedisCluster with context config as auth, creating problems like configure TLS config like the redis extension documentation says:
https://github.com/phpredis/phpredis/blob/develop/cluster.md#creating-and-connecting-to-a-cluster