refactor(async-queue): rename $queue property to $pool in ConsumerProcess#7615
Merged
limingxinleo merged 4 commits intohyperf:masterfrom Nov 12, 2025
Merged
Conversation
…cess
Renamed the protected property from `$queue` to `$pool` to better reflect its purpose as a connection pool identifier. Added backward compatibility support for existing code that still uses the `$queue` property.
Changes:
- Renamed `$queue` to `$pool` throughout ConsumerProcess class
- Added backward compatibility check in constructor for legacy `$queue` property
- Updated process name from "queue.{$queue}" to "pool.{$pool}"
- Marked as deprecated: $queue property will be removed in v3.2
This change improves code clarity while maintaining backward compatibility for existing implementations.
limingxinleo
approved these changes
Nov 12, 2025
huangdijia
added a commit
to huangdijia/hyperf
that referenced
this pull request
Nov 14, 2025
…ency This change completes the terminology standardization in the async-queue component by renaming the remaining queue-related identifiers to pool-related ones, aligning with the ConsumerProcess refactoring in hyperf#7615. Changes: - Renamed JobInterface::getQueueName() to getPoolName() - Renamed Job::getQueueName() to getPoolName() - Renamed $queue parameter to $pool in dispatch() function
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
ConsumerProcessclass in the async-queue component by renaming the$queueproperty to$poolto better reflect its purpose as a connection pool identifier rather than a queue name.Changes
$queueto$poolinConsumerProcessclass$queueproperty$queueto$poolthroughout the class"queue.{$queue}"to"pool.{$pool}"Backward Compatibility
The change maintains backward compatibility by checking if the legacy
$queueproperty exists and using its value if present. A comment has been added indicating this compatibility layer will be removed in v3.2.Migration Path
For existing implementations extending
ConsumerProcess:Before:
After:
Existing code using the old
$queueproperty will continue to work until v3.2.Test Plan
$queueand new$poolproperty declarations