refactor(async-queue): rename getQueueName to getPoolName for consistency#7625
Merged
limingxinleo merged 5 commits intohyperf:3.2from Nov 14, 2025
Merged
Conversation
…ency This change completes the terminology standardization in the async-queue component by renaming the remaining queue-related identifiers to pool-related ones, aligning with the ConsumerProcess refactoring in hyperf#7615. Changes: - Renamed JobInterface::getQueueName() to getPoolName() - Renamed Job::getQueueName() to getPoolName() - Renamed $queue parameter to $pool in dispatch() function
… getPoolName and $queue to $pool
limingxinleo
approved these changes
Nov 14, 2025
limingxinleo
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the terminology standardization in the async-queue component by renaming the remaining queue-related identifiers to pool-related ones. This change aligns with the recent refactoring in #7615 where the
$queueproperty was renamed to$poolinConsumerProcess.Changes
JobInterface::getQueueName()togetPoolName()Job::getQueueName()togetPoolName()$queueparameter to$poolindispatch()functionMotivation
The async-queue component uses "pool" terminology to refer to different queue configurations (e.g., "default", "custom"). This refactoring ensures consistency across the codebase by using "pool" instead of "queue" in method and parameter names.
Breaking Changes
Classes implementing
JobInterfacewill need to renamegetQueueName()togetPoolName():Test Plan
getQueueName()exist in the codebase