fix(database): correct return type for Blueprint::foreign()#7682
Merged
limingxinleo merged 1 commit intohyperf:masterfrom Jan 25, 2026
Merged
Conversation
The foreign() method always returns ForeignKeyDefinition, not Fluent|ForeignKeyDefinition as the docblock claimed. This caused phpstan errors in downstream code: Call to an undefined method Hyperf\Support\Fluent::references() The method creates a ForeignKeyDefinition and returns it directly, so the union type was misleading. ForeignKeyDefinition extends Fluent and has the references(), on(), onDelete() etc. methods via @method annotations.
98a3e99 to
51dc0ac
Compare
limingxinleo
approved these changes
Jan 25, 2026
limingxinleo
approved these changes
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
foreign()method always returnsForeignKeyDefinition, notFluent|ForeignKeyDefinitionas the docblock claimed. This caused phpstan errors in downstream code:Call to an undefined method Hyperf\Support\Fluent::references()The method creates a
ForeignKeyDefinitionand returns it directly, so the union type was wrong.ForeignKeyDefinitionextendsFluentand has the references(), on(), onDelete() etc. methods via @method annotations.