Support PHPUnit versions 5 and 6#43
Closed
carusogabriel wants to merge 1 commit intoleproxy:masterfrom
carusogabriel:phpunit
Closed
Support PHPUnit versions 5 and 6#43carusogabriel wants to merge 1 commit intoleproxy:masterfrom carusogabriel:phpunit
carusogabriel wants to merge 1 commit intoleproxy:masterfrom
carusogabriel:phpunit
Conversation
clue
approved these changes
Nov 17, 2017
Member
clue
left a comment
There was a problem hiding this comment.
Thank for you digging into this and filing this PR! The changes LGTM, I will get this in once the failing test suite has been fixed 👍
Author
|
@clue I've looked at the Travis CI log failed and sounds like the fails isn't related to this PR 😨 |
Member
|
@carusogabriel Sorry for the delay, I've just fixed the Travis build error with #44 I very much appreciate your effort with this PR, however this project has currently locked the PHP version to 5.4, so this updated PHPUnit actually has no effect (see build output even for newer PHP versions). I still think supporting a newer PHPUnit version would make sense, but at this point I'm unsure if it's worth the effort? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.