Conversation
5ddb9b4 to
7b87f47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a small update to add support for legacy PHP 5.3 which I've looked into a while back. This PR shows how this requires only smaller changes in the code and mostly boils down to locking some (outdated) dependencies. In particular, this means this would need to downgrade react/promise to v1.x and as such means that we can not take advantage of the recent very significant memory and performance improvements in v2.6/v2.7. Because of this, I'm mostly filing this for the reference and do not plan to merge this any time soon. Also, I don't see a particular demand for legacy PHP versions anymore, so I'll just leave this here for now.