Deleting a FIFO message with an expired receipt handle should raise an error#12442
Merged
Deleting a FIFO message with an expired receipt handle should raise an error#12442
Conversation
LocalStack Community integration with Pro 2 files ± 0 2 suites ±0 1h 13m 6s ⏱️ - 39m 58s Results for commit bf73c2c. ± Comparison against base commit 1005e96. This pull request removes 1262 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
gregfurman
requested changes
Mar 27, 2025
Contributor
gregfurman
left a comment
There was a problem hiding this comment.
Have left some comments mostly related to snapshot testing. Feel free to ignore my nits 🙂
thrau
approved these changes
Mar 31, 2025
Member
thrau
left a comment
There was a problem hiding this comment.
LGTM! thanks for fixing this :-)
just two minor nits, nothing blocking
0ce4b09 to
bf73c2c
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As per title. FIFO messages should not be deleted if the provided receipt handle has expired, tests against AWS failed consistently. Reversely, the same test succeeded consistently on standard queues, making fifo specific code necessary.
fixes #12278
Changes
_pre_delete_checkshook when removing messages, because this behaviour is fifo specific, and a complete remodel of the delete method to separate standard and fifo behaviour to make this cleaner was out of scope for this PR.