Skip to content

Retire Elemental MediaStore #13484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
viren-nadkarni merged 1 commit into from
Dec 16, 2025
Merged

Retire Elemental MediaStore #13484

viren-nadkarni merged 1 commit into from
Dec 16, 2025

Conversation

@viren-nadkarni
Copy link
Member

@viren-nadkarni viren-nadkarni commented Dec 9, 2025

Changes

This PR removes all code related to Elemental MediaStore.

Related

Closes: PNX-561

@viren-nadkarni viren-nadkarni self-assigned this Dec 9, 2025
@viren-nadkarni viren-nadkarni added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Dec 9, 2025
@github-actions
Copy link

github-actions bot commented Dec 9, 2025 •
edited
Loading

S3 Image Test Results (AMD64 / ARM64)

    2 files  ±0      2 suites  ±0   8m 1s ⏱️ -3s
  552 tests ±0    500 ✅ ±0   52 💤 ±0  0 ❌ ±0 
1 104 runs  ±0  1 000 ✅ ±0  104 💤 ±0  0 ❌ ±0 

Results for commit b2dc920. ± Comparison against base commit bca5595.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 999 tests   - 1   21 156 ✅  - 1   6m 22s ⏱️ -1s
     1 suites ±0    1 843 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit b2dc920. ± Comparison against base commit bca5595.

This pull request removes 1 test. 
tests.unit.aws.test_connect.TestClientFactory ‑ test_typed_client_creation[mediastore]

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   2m 49s ⏱️ -8s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit b2dc920. ± Comparison against base commit bca5595.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 34m 49s ⏱️
5 521 tests 4 965 ✅ 556 💤 0 ❌
5 527 runs  4 965 ✅ 562 💤 0 ❌

Results for commit b2dc920.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 57m 53s ⏱️ + 1m 59s
5 141 tests ±0  4 745 ✅ ±0  396 💤 ±0  0 ❌ ±0 
5 143 runs  ±0  4 745 ✅ ±0  398 💤 ±0  0 ❌ ±0 

Results for commit b2dc920. ± Comparison against base commit bca5595.

♻️ This comment has been updated with latest results.

@aidehn aidehn added this to the 4.13 milestone Dec 10, 2025
@viren-nadkarni viren-nadkarni marked this pull request as ready for review December 15, 2025 07:49
alexrashed
alexrashed approved these changes Dec 15, 2025
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the thorough cleanup after the companion in community has already removed the service! 💯 🧹

@viren-nadkarni viren-nadkarni merged commit 96eea38 into main Dec 16, 2025
49 checks passed
@viren-nadkarni viren-nadkarni deleted the retire-mediastore branch December 16, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexrashed alexrashed alexrashed approved these changes

@thrau thrau Awaiting requested review from thrau thrau is a code owner

@silv-io silv-io Awaiting requested review from silv-io silv-io is a code owner

@k-a-il k-a-il Awaiting requested review from k-a-il k-a-il is a code owner

@bentsku bentsku Awaiting requested review from bentsku bentsku is a code owner

@sannya-singal sannya-singal Awaiting requested review from sannya-singal

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees

@viren-nadkarni viren-nadkarni

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.13

Development

Successfully merging this pull request may close these issues.

4 participants

@viren-nadkarni @alexrashed @aidehn