Skip to content

Conversation

@dfangl
Copy link
Member

@dfangl dfangl commented Dec 11, 2025

Motivation

We currently do not support specifying the cpu shares or the memory limit (https://docs.docker.com/engine/containers/resource_constraints/) for the container.
However, we need a possibility to specify those values for parity for some compute services.

The tests for these work on both cgroup v1 and v2, however for some values a conversion is necessary in the assertions.

Changes

  • Allow specification of the cpu-shares and mem-limit container configuration values.

Tests

  • Tests for the docker client are added, more testing of that functionaity will be done as part of the feature depending on these configuration options.

Related

Fixes UNC-147

@dfangl dfangl added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Dec 11, 2025
@dfangl dfangl requested a review from simonrw December 11, 2025 14:15
@github-actions
Copy link

github-actions bot commented Dec 11, 2025

Test Results - Preflight, Unit

23 001 tests  ±0   21 158 ✅ ±0   6m 31s ⏱️ +8s
     1 suites ±0    1 843 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 2cab92d. ± Comparison against base commit ca6b22b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 56m 22s ⏱️ +59s
5 141 tests ±0  4 745 ✅ ±0  396 💤 ±0  0 ❌ ±0 
5 143 runs  ±0  4 745 ✅ ±0  398 💤 ±0  0 ❌ ±0 

Results for commit 2cab92d. ± Comparison against base commit ca6b22b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 3s ⏱️ ±0s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 2cab92d. ± Comparison against base commit ca6b22b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks for expanding the docker functionality!

@dfangl dfangl force-pushed the docker/support-cpu-shares-mem-limit branch from d0e1d25 to 2cab92d Compare December 11, 2025 17:03
@github-actions
Copy link

Test Results (amd64) - Integration, Bootstrap

    5 files  ±0      5 suites  ±0   2h 35m 22s ⏱️ -5s
5 525 tests +4  4 967 ✅ +2  558 💤 +2  0 ❌ ±0 
5 531 runs  +4  4 967 ✅ +2  564 💤 +2  0 ❌ ±0 

Results for commit 2cab92d. ± Comparison against base commit ca6b22b.

@dfangl dfangl merged commit 35f78d8 into main Dec 19, 2025
63 of 65 checks passed
@dfangl dfangl deleted the docker/support-cpu-shares-mem-limit branch December 19, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants