DNS: Move tests to integration tests, reenable skipped test #13510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results - Preflight, Unit22 979 tests - 22 21 137 ✅ - 21 6m 22s ⏱️ -1s Results for commit 8a2dabc. ± Comparison against base commit ca6b22b. This pull request removes 22 tests.♻️ This comment has been updated with latest results. |
LocalStack Community integration with Pro2 files 2 suites 35s ⏱️ Results for commit 8a2dabc. |
| dns_server.add_host("example.org", TargetRecord("127.0.0.1", RecordType.A)) | ||
| answer = query_dns("nonexistent.example.org", "A") | ||
| dns_server.add_host("example.com", TargetRecord("127.0.0.1", RecordType.A)) | ||
| answer = query_dns("nonexistent.example.com", "A") |
Contributor
There was a problem hiding this comment.
This actually doesn't work for me. It's because nonexistent.example.com returns SERVFAIL rather than NXDOMAIN (although that might be temporary?)
Expected :<Rcode.NXDOMAIN: 3>
Actual :<Rcode.SERVFAIL: 2>
| These tests use the `example.org` and `example.com` domains for testing, and also tests the fallback to the public DNS | ||
| Changes in the upstream name resolution of those domains might lead to test failures. | ||
|
|
||
| TODO we should investigate creating our own test domain with a fixed behavior to avoid potential test failures |
Contributor
There was a problem hiding this comment.
Is localstack.cloud something we could use? Unfortunately, creating an additional test domain would cost money, and the associated yearly management of keeping the domain alive.
Test Results (amd64) - Integration, Bootstrap 5 files ± 0 5 suites ±0 9m 21s ⏱️ - 2h 26m 6s Results for commit 8a2dabc. ± Comparison against base commit ca6b22b. This pull request removes 5495 and adds 22 tests. Note that renamed tests count towards both. |
simonrw
approved these changes
Dec 15, 2025
Contributor
simonrw
left a comment
There was a problem hiding this comment.
I think these tests are inherently fragile unless we implement our own domain name but the overhead of that at the moment is IMO more than handling these issues every ~year or so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently our DNS tests are marked as unit tests. However, they are not actually unit tests, as they test the end to end behavior of the DNS server, including calls to upstream DNS servers.
This PR will correctly move them to the integration tests. (cc @peter-smith-phd)
Also, recently it seems that
example.orgwas moved to cloudflare DNS, which leads to a different response code for one of our queries - NOERROR (with an empty response) instead of NXDOMAIN.By moving to
example.comfor this test we for now circumvent this issue - as a simple change in the assertion is not sufficient, since this change is still not propagated everywhere (and might even change in the future again).Changes
example.comdomain for skipped tests to reenable.Tests
Related
Fixes UNC-164