Skip to content

Conversation

@sannya-singal
Copy link
Contributor

Motivation

This PR fixes the issue where _custom_key_material_ does not work for RSA_2048 keys in KMS causing validation errors.

Changes

This PR skips tag value length validation for _custom_key_material_ tags while enabling the RSA keys to load and use custom key material when provided and adds test_create_key_custom_key_material_rsa_2048 to validate tha changes.

Related

Closes #13375
Fixes FLC-185

@sannya-singal sannya-singal self-assigned this Dec 12, 2025
@sannya-singal sannya-singal added aws:kms AWS Key Management Service semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Dec 12, 2025
@github-actions
Copy link

LocalStack Community integration with Pro

  2 files    2 suites   4m 35s ⏱️
767 tests 759 ✅  8 💤 0 ❌
769 runs  759 ✅ 10 💤 0 ❌

Results for commit 4c2a504.

@github-actions
Copy link

Test Results - Preflight, Unit

23 001 tests  ±0   21 158 ✅ ±0   6m 21s ⏱️ +3s
     1 suites ±0    1 843 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 4c2a504. ± Comparison against base commit d6882f9.

@github-actions
Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   2m 55s ⏱️ -7s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 4c2a504. ± Comparison against base commit d6882f9.

@github-actions
Copy link

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   17m 20s ⏱️
791 tests 783 ✅  8 💤 0 ❌
797 runs  783 ✅ 14 💤 0 ❌

Results for commit 4c2a504.

@sannya-singal sannya-singal marked this pull request as ready for review December 12, 2025 10:35
@sannya-singal sannya-singal requested a review from k-a-il December 12, 2025 10:35
Copy link
Contributor

@k-a-il k-a-il left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, LGTM 👍

@sannya-singal sannya-singal merged commit b5316b0 into main Dec 16, 2025
59 checks passed
@sannya-singal sannya-singal deleted the flc-185 branch December 16, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws:kms AWS Key Management Service docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: _custom_key_material_ does not seem to work for RSA_2048

3 participants