Sns: v2 data protection operations #13525

baermat · 2025-12-15T14:17:59Z

Motivation

Adds methods for creating and retrieving data protection policies. These policies are not enforced with this PR, since the methods are not present in moto right now to begin with.
closes PNX-74
closes PNX-378

Changes

adds put_data_protection_policy, get_data_protection_policy

Tests

Test Results - Preflight, Unit

22 981 tests +3 21 139 ✅ +3 6m 50s ⏱️ +18s
1 suites ±0 1 842 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 734c2de. ± Comparison against base commit 4532ad6.

This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both.

tests.unit.aws.test_connect.TestClientFactory ‑ test_typed_client_creation[mediastore]

tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[account-rest-json-GetGovCloudAccountInformation]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[ce-json-ListCostCategoryResourceAssociations]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[quicksight-rest-json-GetIdentityContext]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[redshift-serverless-json-GetIdentityCenterAuthToken]

♻️ This comment has been updated with latest results.

github-actions · 2025-12-15T14:42:38Z

Test Results - Alternative Providers

208 tests 164 ✅ 2m 5s ⏱️
1 suites 44 💤
1 files 0 ❌

Results for commit 734c2de.

♻️ This comment has been updated with latest results.

github-actions · 2025-12-15T14:43:08Z

Test Results (amd64) - Acceptance

7 tests ±0 5 ✅ ±0 3m 0s ⏱️ +3s
1 suites ±0 2 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 734c2de. ± Comparison against base commit 4532ad6.

♻️ This comment has been updated with latest results.

github-actions · 2025-12-15T15:38:57Z

Test Results (amd64) - Integration, Bootstrap

5 files 5 suites 1h 28m 47s ⏱️
3 146 tests 2 976 ✅ 170 💤 0 ❌
3 154 runs 2 978 ✅ 176 💤 0 ❌

Results for commit 734c2de.

♻️ This comment has been updated with latest results.

github-actions · 2025-12-15T15:39:19Z

LocalStack Community integration with Pro

2 files ± 0 2 suites ±0 59m 54s ⏱️ - 57m 13s
3 122 tests - 2 024 2 949 ✅ - 1 801 173 💤 - 223 0 ❌ ±0
3 126 runs - 2 022 2 951 ✅ - 1 799 175 💤 - 223 0 ❌ ±0

Results for commit 734c2de. ± Comparison against base commit 4532ad6.

This pull request removes 2030 and adds 6 tests. Note that renamed tests count towards both.

tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayVpcLink ‑ test_create_vpc_link_invalid_parameters
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayVpcLink ‑ test_delete_vpc_link_invalid_id
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayVpcLink ‑ test_get_vpc_link_invalid_id
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayVpcLink ‑ test_update_vpc_link_invalid_id
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayVpcLink ‑ test_vpc_link_lifecycle
tests.aws.services.sns.test_sns.TestSNSTopicCrudV2 ‑ test_data_protection_policy_crud

This pull request removes 224 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.

tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input4-FAILED]
tests.aws.scenario.mythical_mysfits.test_mythical_misfits.TestMythicalMisfitsScenario ‑ test_deployed_infra_state
tests.aws.scenario.mythical_mysfits.test_mythical_misfits.TestMythicalMisfitsScenario ‑ test_populate_data
tests.aws.scenario.mythical_mysfits.test_mythical_misfits.TestMythicalMisfitsScenario ‑ test_user_clicks_are_stored
tests.aws.services.cloudcontrol.test_cloudcontrol_api.TestCloudControlResourceApi ‑ test_api_exceptions
tests.aws.services.cloudcontrol.test_cloudcontrol_api.TestCloudControlResourceApi ‑ test_create_exceptions
tests.aws.services.cloudcontrol.test_cloudcontrol_api.TestCloudControlResourceApi ‑ test_create_invalid_desiredstate
tests.aws.services.cloudcontrol.test_cloudcontrol_api.TestCloudControlResourceApi ‑ test_double_create_with_client_token
tests.aws.services.cloudcontrol.test_cloudcontrol_api.TestCloudControlResourceApi ‑ test_lifecycle
…

tests.aws.services.sns.test_sns.TestSNSTopicCrudV2 ‑ test_data_protection_policy_crud

♻️ This comment has been updated with latest results.

bentsku

Nice work! Nice that we have support for more operations now! I've checked the logic and I think the EffectiveDeliveryPolicy new logic is not correct, this is added at topic creation I believe. I've added more context in the comment 👍

bentsku · 2025-12-15T21:20:53Z

tests/aws/services/sns/test_sns.py

+        # check if policy shows up in the attributes
+        response = aws_client.sns.get_topic_attributes(TopicArn=topic_arn)
+        snapshot.match("get-topic-attributes", response)


nit: could we maybe call get_topic_attributes before calling put_data_protection_policy to see the before/after? I'm curious about the EffectiveDeliveryPolicy being created 😄

I've given it a try locally and I can confirm that the EffectiveDeliveryPolicy is already present before the call, so I think the logic needs to be updated. This can be done either in this PR (add the policy at topic creation) or in another PR (add a snapshot skip for the delivery policy for now in this PR and add the policy in a follow-up PR)

You are right. I moved this to the topic creation, and as a result, also removed the EffectiveDeliveryPolicy from most of the snapshot skips :)

bentsku

LGTM! Thanks for addressing the comment! I've added another comment regarding the EffectiveDeliveryPolicy, to make sure we're updating it when updating the DeliveryPolicy but this should be tackled as a follow-up 👍 nice work!

bentsku · 2025-12-17T16:19:49Z

localstack-core/localstack/services/sns/v2/provider.py

    return default_attributes


+def _create_default_effective_delivery_policy():


I believe this is somewhat of the default: I think the behavior is somewhat different: the EffectiveDeliveryPolicy is a merged value between the default value and what would be set for DeliveryPolicy. Meaning if you set for example the defaultRequestPolicy in your DeliveryPolicy, you effective delivery policy will be a merged between the default value, and that value you set, effectively being the "Effective" value.

I believe we will need to implement this behavior, it would be a great addition.

Doesn't need to be implemented in this PR as we had an issue before already, but it would be nice to keep track of this 👍 (basically updating the effective policy when updating the delivery policy)

baermat added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Dec 15, 2025

baermat added 2 commits December 15, 2025 15:23

WIP

91ae535

add data protection policy operations, add test

82ab790

baermat force-pushed the sns/v2-data-protection branch from ad28068 to 82ab790 Compare December 15, 2025 14:24

baermat marked this pull request as ready for review December 15, 2025 14:26

baermat requested a review from bentsku as a code owner December 15, 2025 14:26

fix test

c8b8597

bentsku reviewed Dec 15, 2025

View reviewed changes

baermat added 3 commits December 17, 2025 14:36

fixed default policy creation, removed snapshot skip as a result

30f5c09

fix snapshot skip

685f8af

fix test for v1

734c2de

bentsku self-requested a review December 17, 2025 16:13

bentsku approved these changes Dec 17, 2025

View reviewed changes

baermat merged commit 9d08473 into main Dec 17, 2025
43 checks passed

baermat deleted the sns/v2-data-protection branch December 17, 2025 16:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sns: v2 data protection operations #13525

Sns: v2 data protection operations #13525

Uh oh!

baermat commented Dec 15, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 15, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 15, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 15, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 15, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 15, 2025 •

edited

Loading

Uh oh!

bentsku left a comment

Uh oh!

bentsku Dec 15, 2025

Uh oh!

baermat Dec 17, 2025

Uh oh!

bentsku left a comment

Uh oh!

bentsku Dec 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		return default_attributes


		def _create_default_effective_delivery_policy():

Uh oh!

Sns: v2 data protection operations #13525

Sns: v2 data protection operations #13525

Uh oh!

Conversation

baermat commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Changes

Tests

Related

Uh oh!

github-actions bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results - Preflight, Unit

Uh oh!

github-actions bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results - Alternative Providers

Uh oh!

github-actions bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results (amd64) - Acceptance

Uh oh!

github-actions bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results (amd64) - Integration, Bootstrap

Uh oh!

github-actions bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

LocalStack Community integration with Pro

Uh oh!

bentsku left a comment

Choose a reason for hiding this comment

Uh oh!

bentsku Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

baermat Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

bentsku left a comment

Choose a reason for hiding this comment

Uh oh!

bentsku Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

baermat commented Dec 15, 2025 •

edited

Loading

github-actions bot commented Dec 15, 2025 •

edited

Loading

github-actions bot commented Dec 15, 2025 •

edited

Loading

github-actions bot commented Dec 15, 2025 •

edited

Loading

github-actions bot commented Dec 15, 2025 •

edited

Loading

github-actions bot commented Dec 15, 2025 •

edited

Loading