Skip to content

Apigw/fix vpc links return value #13532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cloutierMat merged 5 commits into from
Dec 16, 2025
Merged

Apigw/fix vpc links return value #13532

cloutierMat merged 5 commits into from
Dec 16, 2025

Conversation

@cloutierMat
Copy link
Member

@cloutierMat cloutierMat commented Dec 16, 2025 •
edited
Loading

Motivation

This pr improves on vpc-links Create operation. The previous behavior would only create an id and mark as AVAILABLE, ignoring any added values. We will now properly add all but tags to the vpc links.

I opted not to add tags right away as to push the fix faster to our customer. I will follow up shortly with proper tag handling as they can't simply be added to the VpcLink data model and should use the TAGS model

Changes

  • support values of CreateVpcLink

Tests

  • added basic lifecycle test
  • plus a few test over RUD operation that ai added (work through the ai spike day). I figured they don't hurt, but didn't think it necessary to go through the rabbit hole of expanding on them much at the moment.

Related

closes UNC-168

@cloutierMat cloutierMat added aws:apigateway Amazon API Gateway semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: needed Pull request should be mentioned in the release notes labels Dec 16, 2025
@cloutierMat cloutierMat added this to the 4.13 milestone Dec 16, 2025
@github-actions
Copy link

github-actions bot commented Dec 16, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   18m 21s ⏱️ - 1h 36m 58s
1 315 tests  - 3 832  1 234 ✅  - 3 517  81 💤  - 315  0 ❌ ±0 
1 317 runs   - 3 832  1 234 ✅  - 3 517  83 💤  - 315  0 ❌ ±0 

Results for commit 50e5a07. ± Comparison against base commit 532d755.

This pull request removes 3837 and adds 5 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayVpcLink ‑ test_create_vpc_link_invalid_parameters
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayVpcLink ‑ test_delete_vpc_link_invalid_id
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayVpcLink ‑ test_get_vpc_link_invalid_id
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayVpcLink ‑ test_update_vpc_link_invalid_id
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayVpcLink ‑ test_vpc_link_lifecycle

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 16, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 981 tests  ±0   21 139 ✅ ±0   6m 23s ⏱️ +8s
     1 suites ±0    1 842 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 50e5a07. ± Comparison against base commit 532d755.

♻️ This comment has been updated with latest results.

@cloutierMat cloutierMat force-pushed the apigw/fix-vpc-links-return-value branch from ea952c1 to d28b9bd Compare December 16, 2025 15:33
@cloutierMat cloutierMat force-pushed the apigw/fix-vpc-links-return-value branch from d28b9bd to 48031d5 Compare December 16, 2025 15:41
@github-actions
Copy link

github-actions bot commented Dec 16, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   2m 59s ⏱️ -3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 50e5a07. ± Comparison against base commit 532d755.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 16, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   35m 10s ⏱️
1 339 tests 1 259 ✅ 80 💤 0 ❌
1 345 runs  1 259 ✅ 86 💤 0 ❌

Results for commit 50e5a07.

♻️ This comment has been updated with latest results.

@cloutierMat cloutierMat marked this pull request as ready for review December 16, 2025 16:17
@cloutierMat cloutierMat requested a review from bentsku as a code owner December 16, 2025 16:17
bentsku
bentsku approved these changes Dec 16, 2025
View reviewed changes
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This looks good, and painful to test 😅 thanks for jumping on this! 💯

@cloutierMat cloutierMat merged commit ee0d438 into main Dec 16, 2025
42 checks passed
@cloutierMat cloutierMat deleted the apigw/fix-vpc-links-return-value branch December 16, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bentsku bentsku bentsku approved these changes

Assignees

No one assigned

Labels

aws:apigateway Amazon API Gateway docs: skip Pull request does not require documentation changes notes: needed Pull request should be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.13

Development

Successfully merging this pull request may close these issues.

3 participants

@cloutierMat @bentsku