Skip to content

Conversation

@k-a-il
Copy link
Contributor

@k-a-il k-a-il commented Dec 17, 2025

Motivation

A failing unit test is blocking the main pipeline and MA/MR pipeline

Changes

  • Skip failing DNS unit test unit.test_dns_server.TestDNSServer.test_dns_server_subdomain_of_route

Related

FLC-248

@k-a-il k-a-il self-assigned this Dec 17, 2025
@k-a-il k-a-il added area: ci Running LocalStack in CI environments semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Dec 17, 2025
@k-a-il k-a-il requested review from dfangl and simonrw December 17, 2025 08:34
@github-actions
Copy link

LocalStack Community integration with Pro

2 files  ±    0  2 suites  ±0   36s ⏱️ - 1h 56m 4s
2 tests  - 5 150  0 ✅  - 4 756  2 💤  - 394  0 ❌ ±0 
4 runs   - 5 150  0 ✅  - 4 756  4 💤  - 394  0 ❌ ±0 

Results for commit 1f19a66. ± Comparison against base commit ee0d438.

This pull request removes 5150 tests.
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@github-actions
Copy link

Test Results - Preflight, Unit

22 981 tests  ±0   21 139 ✅ ±0   6m 13s ⏱️ -1s
     1 suites ±0    1 842 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 1f19a66. ± Comparison against base commit ee0d438.

@github-actions
Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 3s ⏱️ -13s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 1f19a66. ± Comparison against base commit ee0d438.

@github-actions
Copy link

Test Results (amd64) - Integration, Bootstrap

 5 files  ±    0   5 suites  ±0   9m 9s ⏱️ - 2h 26m 24s
48 tests  - 5 506  45 ✅  - 4 952  3 💤  - 553  0 ❌  - 1 
54 runs   - 5 506  45 ✅  - 4 952  9 💤  - 553  0 ❌  - 1 

Results for commit 1f19a66. ± Comparison against base commit ee0d438.

This pull request removes 5506 tests.
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…
This pull request skips 1 test.
tests.integration.dns.test_dns_server.TestDNSServer ‑ test_dns_server_subdomain_of_route

@k-a-il k-a-il merged commit 14d1ccb into main Dec 17, 2025
60 checks passed
@k-a-il k-a-il deleted the skip-failing-dns-unit-test branch December 17, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci Running LocalStack in CI environments docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants