Skip to content

fix: replace hardcoded region in SNS test#13542

Merged
baermat merged 1 commit intomainfrom
sns/fix-ma-pipeline
Dec 18, 2025
Merged

fix: replace hardcoded region in SNS test#13542
baermat merged 1 commit intomainfrom
sns/fix-ma-pipeline

Conversation

@baermat
Copy link
Member

@baermat baermat commented Dec 18, 2025 •
edited
Loading

Motivation

A hard-coded region parameter slipped through into main and this is breaking the MA/MR pipeline. This PR addresses this.

Changes

Tests

Here is a manual run of the MA/MR pipeline which passed

Related

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Test Results - Preflight, Unit

22 982 tests  ±0   21 140 ✅ ±0   6m 22s ⏱️ +14s
     1 suites ±0    1 842 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 984acfa. ± Comparison against base commit 033f449.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025 •
edited
Loading

Test Results (MA/MR) - Preflight, Unit

22 982 tests  ±0   21 140 ✅ ±0   6m 22s ⏱️ +27s
     1 suites ±0    1 842 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 984acfa. ± Comparison against base commit 033f449.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Test Results - Alternative Providers

208 tests   - 1 261   164 ✅  - 724   2m 6s ⏱️ - 31m 1s
  1 suites  -     4    44 💤  - 537 
  1 files    -     4     0 ❌ ±  0 

Results for commit 984acfa. ± Comparison against base commit 033f449.

This pull request removes 1261 tests. 
tests.aws.services.cloudformation.api.test_changesets ‑ test_autoexpand_capability_requirement
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_and_then_remove_non_supported_resource_change_set
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_and_then_remove_supported_resource_change_set
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_and_then_update_refreshes_template_metadata
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_create_existing
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_invalid_params
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_missing_stackname
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_no_changes
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_update_nonexisting
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_update_without_parameters
…

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   2m 59s ⏱️ -2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 984acfa. ± Comparison against base commit 033f449.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files  ±    0      5 suites  ±0   1h 28m 41s ⏱️ - 1h 5m 16s
3 145 tests  - 2 410  2 975 ✅  - 2 022  170 💤  - 388  0 ❌ ±0 
3 154 runs   - 2 407  2 978 ✅  - 2 019  176 💤  - 388  0 ❌ ±0 

Results for commit 984acfa. ± Comparison against base commit 033f449.

This pull request removes 2410 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 0m 6s ⏱️ - 54m 6s
3 121 tests  - 2 032  2 948 ✅  - 1 808  173 💤  - 224  0 ❌ ±0 
3 126 runs   - 2 029  2 951 ✅  - 1 805  175 💤  - 224  0 ❌ ±0 

Results for commit 984acfa. ± Comparison against base commit 033f449.

This pull request removes 2032 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@baermat baermat added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Dec 18, 2025
@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Test Results (MA/MR) - Alternative Providers

208 tests   - 1 261   164 ✅  - 723   2m 9s ⏱️ - 30m 53s
  1 suites  -     4    44 💤  - 537 
  1 files    -     4     0 ❌  -   1 

Results for commit 984acfa. ± Comparison against base commit 033f449.

This pull request removes 1261 tests. 
tests.aws.services.cloudformation.api.test_changesets ‑ test_autoexpand_capability_requirement
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_and_then_remove_non_supported_resource_change_set
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_and_then_remove_supported_resource_change_set
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_and_then_update_refreshes_template_metadata
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_create_existing
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_invalid_params
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_missing_stackname
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_no_changes
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_update_nonexisting
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_update_without_parameters
…

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Test Results (amd64, MA/MR) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 3s ⏱️ -4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 984acfa. ± Comparison against base commit 033f449.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Test Results (amd64, MA/MR) - Integration, Bootstrap

    5 files  ±    0      5 suites  ±0   1h 27m 50s ⏱️ - 1h 8m 29s
3 145 tests  - 2 410  2 975 ✅  - 2 022  170 💤  - 388  0 ❌ ±0 
3 154 runs   - 2 407  2 978 ✅  - 2 019  176 💤  - 388  0 ❌ ±0 

Results for commit 984acfa. ± Comparison against base commit 033f449.

This pull request removes 2410 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@baermat baermat marked this pull request as ready for review December 18, 2025 10:02
@baermat baermat requested a review from bentsku as a code owner December 18, 2025 10:02
bentsku
bentsku approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for missing it in the review, nice and clean fix 💯

@baermat baermat requested a review from k-a-il December 18, 2025 10:02
@baermat baermat merged commit b613fb9 into main Dec 18, 2025
114 of 119 checks passed
@baermat baermat deleted the sns/fix-ma-pipeline branch December 18, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bentsku bentsku bentsku approved these changes

@k-a-il k-a-il Awaiting requested review from k-a-il

Assignees

No one assigned

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baermat @bentsku