Skip to content

Fix Lambda CI log pollution issues #13546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joe4dev merged 1 commit into from
Dec 19, 2025
Merged

Fix Lambda CI log pollution issues #13546

joe4dev merged 1 commit into from
Dec 19, 2025

Conversation

@joe4dev
Copy link
Member

@joe4dev joe4dev commented Dec 18, 2025

Motivation

Our CI logs are very noisy, including many avoidable WARNING and ERROR messages, making it difficult to debug real issues. In particular:

  • 57 errors and stack traces leaking into other tests from an ESM poller that is not shut down properly:

localstack.services.lambda_.event_source_mapping.esm_worker : Error while polling messages for event source arn:aws:dynamodb:us-east-1:000000000000:table/table-612184b5/stream/2025-12-15T05:07:00.383: An error occurred (ResourceNotFoundException) when calling the DescribeStream operation: Requested resource not found: Stream: arn:aws:dynamodb:us-east-1:000000000000:table/table-612184b5/stream/2025-12-15T05:07:00.383 not found

  • DEBUG: DeleteEventSourceMapping operation: The resource you requested does not exist. gets logged 27 times

Changes

  • Use ESM fixture and fix cleanups (due to lifecycle timings) for test_create_event_filter_criteria_validation
  • Fix unnecessary DeleteEventSourceMapping debug log by catching the ResourceNotFoundException in the fixture. There is no need to delete something that doesn't exist :)
  • Remove some unnecessary parameters (LoggingConfig, MemorySize, Timeout) from Lambda runtime validation tests

Related

Discovered during AI Winter hackathon :)

@joe4dev joe4dev added this to the 4.13 milestone Dec 18, 2025
@joe4dev joe4dev self-assigned this Dec 18, 2025
@joe4dev joe4dev added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Dec 18, 2025
@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Test Results - Preflight, Unit

22 982 tests  ±0   21 140 ✅ ±0   6m 1s ⏱️ -1s
     1 suites ±0    1 842 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 397324c. ± Comparison against base commit b613fb9.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   2m 58s ⏱️ -3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 397324c. ± Comparison against base commit b613fb9.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 41m 26s ⏱️
5 555 tests 4 997 ✅ 558 💤 0 ❌
5 561 runs  4 997 ✅ 564 💤 0 ❌

Results for commit 397324c.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 57m 2s ⏱️ + 1m 57s
5 153 tests ±0  4 756 ✅ ±0  397 💤 ±0  0 ❌ ±0 
5 155 runs  ±0  4 756 ✅ ±0  399 💤 ±0  0 ❌ ±0 

Results for commit 397324c. ± Comparison against base commit b613fb9.

@joe4dev joe4dev marked this pull request as ready for review December 19, 2025 09:19
gregfurman
gregfurman approved these changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@gregfurman gregfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

localstack-core/localstack/testing/pytest/fixtures.py
Comment on lines +1550 to +1551
except aws_client.lambda_.exceptions.ResourceNotFoundException:
pass
Copy link
Contributor

@gregfurman gregfurman Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Can't believe this is all it takes to declutter our logs 🫠

@joe4dev joe4dev merged commit 056da83 into main Dec 19, 2025
55 checks passed
@joe4dev joe4dev deleted the fix-lambda-ci-log-pollution branch December 19, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregfurman gregfurman gregfurman approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@dfangl dfangl Awaiting requested review from dfangl dfangl is a code owner

Assignees

@joe4dev joe4dev

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.13

Development

Successfully merging this pull request may close these issues.

3 participants

@joe4dev @gregfurman