Skip to content

APIGW: improve store typing #13552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bentsku merged 1 commit into from
Dec 22, 2025
Merged

APIGW: improve store typing #13552

bentsku merged 1 commit into from
Dec 22, 2025
+14 −6

Conversation

@bentsku
Copy link
Contributor

@bentsku bentsku commented Dec 19, 2025 •
edited
Loading

Motivation

This PR improves the typing of the API Gateway store to remove imprecise typing.

Changes

  • set the types at the Class annotation level
  • use the generated APIs to type the store instead of plain dict

Tests

Related

@bentsku bentsku added this to the 4.13 milestone Dec 19, 2025
@bentsku bentsku self-assigned this Dec 19, 2025
@bentsku bentsku added aws:apigateway Amazon API Gateway semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Dec 19, 2025
@github-actions
Copy link

github-actions bot commented Dec 19, 2025

Test Results - Preflight, Unit

22 982 tests  ±0   21 140 ✅ ±0   6m 14s ⏱️ +13s
     1 suites ±0    1 842 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 89f8d8e. ± Comparison against base commit 056da83.

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   19m 17s ⏱️ - 1h 37m 55s
1 315 tests  - 3 838  1 234 ✅  - 3 522  81 💤  - 316  0 ❌ ±0 
1 317 runs   - 3 838  1 234 ✅  - 3 522  83 💤  - 316  0 ❌ ±0 

Results for commit 89f8d8e. ± Comparison against base commit 056da83.

This pull request removes 3838 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 1s ⏱️ +12s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 89f8d8e. ± Comparison against base commit 056da83.

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   36m 19s ⏱️
1 339 tests 1 259 ✅ 80 💤 0 ❌
1 345 runs  1 259 ✅ 86 💤 0 ❌

Results for commit 89f8d8e.

@bentsku bentsku marked this pull request as ready for review December 22, 2025 17:59
@bentsku bentsku requested a review from cloutierMat as a code owner December 22, 2025 17:59
cloutierMat
cloutierMat approved these changes Dec 22, 2025
View reviewed changes
Copy link
Member

@cloutierMat cloutierMat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 More Typing 🥳 Thanks @bentsku

@bentsku bentsku merged commit 7f1e6b5 into main Dec 22, 2025
60 checks passed
@bentsku bentsku deleted the fix-apigw-store branch December 22, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cloutierMat cloutierMat cloutierMat approved these changes

Assignees

@bentsku bentsku

Labels

aws:apigateway Amazon API Gateway docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.13

Development

Successfully merging this pull request may close these issues.

3 participants

@bentsku @cloutierMat