Skip to content

Fix KMS model annotations #13563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
giograno merged 2 commits into from
Dec 23, 2025
Merged

Fix KMS model annotations #13563

giograno merged 2 commits into from
Dec 23, 2025

Conversation

@giograno
Copy link
Member

@giograno giograno commented Dec 23, 2025

Motivation

Follow-ups of #13558.

Changes

  • Some minor annotation fixes. I only noticed when trying to serialize KMS Avro records 🙇

Tests

Related

@giograno giograno self-assigned this Dec 23, 2025
@giograno giograno added area: persistence Retain state between LocalStack runs aws:kms AWS Key Management Service semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Dec 23, 2025
@github-actions
Copy link

github-actions bot commented Dec 23, 2025

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   4m 44s ⏱️ - 1h 50m 21s
767 tests  - 4 387  759 ✅  - 3 998   8 💤  - 389  0 ❌ ±0 
769 runs   - 4 387  759 ✅  - 3 998  10 💤  - 389  0 ❌ ±0 

Results for commit d996e7a. ± Comparison against base commit 960e535.

This pull request removes 4387 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@github-actions
Copy link

github-actions bot commented Dec 23, 2025

Test Results - Preflight, Unit

23 046 tests  ±0   21 201 ✅ ±0   6m 8s ⏱️ +5s
     1 suites ±0    1 845 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit d996e7a. ± Comparison against base commit 960e535.

@github-actions
Copy link

github-actions bot commented Dec 23, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 0s ⏱️ +11s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit d996e7a. ± Comparison against base commit 960e535.

@github-actions
Copy link

github-actions bot commented Dec 23, 2025

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   17m 16s ⏱️
791 tests 783 ✅  8 💤 0 ❌
797 runs  783 ✅ 14 💤 0 ❌

Results for commit d996e7a.

@giograno giograno marked this pull request as ready for review December 23, 2025 17:24
@giograno giograno requested a review from k-a-il as a code owner December 23, 2025 17:24
k-a-il
k-a-il approved these changes Dec 23, 2025
View reviewed changes
Copy link
Contributor

@k-a-il k-a-il left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@giograno giograno merged commit 2417384 into main Dec 23, 2025
63 checks passed
@giograno giograno deleted the avro-enable-kms branch December 23, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k-a-il k-a-il k-a-il approved these changes

Assignees

@giograno giograno

Labels

area: persistence Retain state between LocalStack runs aws:kms AWS Key Management Service docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@giograno @k-a-il